Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info() not pure virtual, remove derived implementations and all calls in RMM code including tests. #1426

Closed
Tracked by #1388
harrism opened this issue Jan 18, 2024 · 0 comments · Fixed by #1430
Closed
Tracked by #1388

Make rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info() not pure virtual, remove derived implementations and all calls in RMM code including tests. #1426

harrism opened this issue Jan 18, 2024 · 0 comments · Fixed by #1430
Assignees
@harrism
Labels
cpp Pertains to C++ code feature request New feature or request

Comments

@harrism
Copy link
Member

harrism commented Jan 18, 2024 •
edited
Loading

Part of #1388
@harrism harrism mentioned this issue Jan 18, 2024
Closed
@harrism harrism changed the title Make rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info() nonvirtual, remove derived implemtations, and all calls in RMM code including tests. Make rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info() nonvirtual, remove derived implementations and all calls in RMM code including tests. Jan 18, 2024
@harrism harrism added feature request New feature or request cpp Pertains to C++ code labels Jan 18, 2024
@harrism harrism self-assigned this Jan 18, 2024
This was referenced Jan 18, 2024
Closed
Merged
rapids-bot bot pushed a commit that referenced this issue Jan 23, 2024
@harrism
Make device_memory_resource::do_get_mem_info() and supports_get_mem_i…
6c904f7 
…nfo() nonvirtual. Remove derived implementations and calls in RMM (#1430)

Closes #1426

As part of #1388, this PR contributes to deprecating and removing all `get_mem_info` functionality from memory resources.  This first PR makes these methods optional without deprecating them. 

 - Makes `rmm::mr::device_memory_resource::supports_get_mem_info()` nonvirtual (and always return false) 
 - Makes `rmm::mr::device_memory_resource::do_get_mem_info()` nonvirtual (and always return `{0, 0}`).
 - Removes all derived implementations of the above.
 - Removes all calls to the above.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1430
@harrism harrism changed the title Make rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info() nonvirtual, remove derived implementations and all calls in RMM code including tests. Make rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info() not pure virtual, remove derived implementations and all calls in RMM code including tests. Jan 25, 2024
@hcho3 hcho3 mentioned this issue May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

Labels
cpp Pertains to C++ code feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
1 participant
@harrism