Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rmm::polymorphic_allocator::resource and remove that functionality after deprecation #1453

Closed
Tracked by #1445
harrism opened this issue Jan 31, 2024 · 2 comments · Fixed by #1555
Closed
Tracked by #1445

Deprecate rmm::polymorphic_allocator::resource and remove that functionality after deprecation #1453

harrism opened this issue Jan 31, 2024 · 2 comments · Fixed by #1555
Labels
cpp Pertains to C++ code feature request New feature or request

Comments

@harrism
Copy link
Member

harrism commented Jan 31, 2024 •
edited
Loading

A search shows that this function is unused in RAPIDS outside of RMM tests and so I expect it is completely unused.
@harrism harrism mentioned this issue Jan 31, 2024
Open
@harrism harrism added feature request New feature or request cpp Pertains to C++ code labels Jan 31, 2024
@miscco
Copy link
Contributor

miscco commented Feb 22, 2024

Closing this in favor of #1455 where we just add a get_upstream_resource method that will be consistent throughout all memory adaptors

@miscco miscco closed this as completed Feb 22, 2024
@harrism
Copy link
Member Author

harrism commented May 7, 2024

Reopening because polymorphic_allocator::resource() still exists and doesn't need to now.

@harrism harrism reopened this May 7, 2024
@harrism harrism mentioned this issue May 7, 2024
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in #1555 May 8, 2024
rapids-bot bot pushed a commit that referenced this issue May 8, 2024
@harrism
Refactor polymorphic allocator to use device_async_resource_ref (#1555)
4f01c55 
Fixes #1540.
Fixes #1453 by removing unused `polymorphic_allocator::resource()`.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Michael Schellenberger Costa (https://github.com/miscco)
  - Rong Ou (https://github.com/rongou)

URL: #1555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cpp Pertains to C++ code feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor polymorphic allocator to use device_async_resource_ref harrism/rmm
2 participants
@harrism @miscco