Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor polymorphic allocator to use device_async_resource_ref #1555

Merged

Conversation

harrism
Copy link
Member

@harrism harrism commented May 7, 2024

Description

Fixes #1540.
Fixes #1453 by removing unused polymorphic_allocator::resource().

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism added breaking Breaking change improvement Improvement / enhancement to an existing function labels May 7, 2024
@harrism harrism self-assigned this May 7, 2024
@harrism harrism requested a review from a team as a code owner May 7, 2024 08:47
@harrism harrism requested review from rongou and vyasr May 7, 2024 08:47
@github-actions github-actions bot added the cpp Pertains to C++ code label May 7, 2024
@harrism harrism requested a review from miscco May 7, 2024 08:47
@harrism
Copy link
Member Author

harrism commented May 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4f01c55 into rapidsai:branch-24.06 May 8, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cpp Pertains to C++ code improvement Improvement / enhancement to an existing function
Projects
Status: Done
3 participants