Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that minimum required CMake version is now 3.23.1 #1098

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Document that minimum required CMake version is now 3.23.1 #1098

merged 1 commit into from
Sep 27, 2022

Conversation

robertmaynard
Copy link
Contributor

Description

With rapids-cmake now requiring CMake 3.23.1 update consumers to correctly express this requirement

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request 3 - Ready for review Ready for review by team doc Documentation non-breaking Non-breaking change labels Sep 23, 2022
@robertmaynard robertmaynard requested review from a team as code owners September 23, 2022 12:44
@robertmaynard robertmaynard requested a review from a team as a code owner September 23, 2022 12:44
@github-actions github-actions bot added CMake conda Python Related to RMM Python API labels Sep 23, 2022
@robertmaynard robertmaynard removed the doc Documentation label Sep 23, 2022
@robertmaynard
Document that minimum required CMake version is now 3.23.1
610fec8 
With rapids-cmake now requiring CMake 3.23.1 update consumers
to correctly express this requirement
@robertmaynard robertmaynard added doc Documentation and removed feature request New feature or request labels Sep 23, 2022
@harrism
Copy link
Member

harrism commented Sep 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8de9847 into rapidsai:branch-22.10 Sep 27, 2022
@robertmaynard robertmaynard deleted the update_cmake_version branch December 27, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
3 - Ready for review Ready for review by team CMake conda doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @harrism @raydouglass