Ensure Logger tests aren't run in parallel #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logger tests all read and write to the same temporary files so make sure the tests are mutually exclusive.
robertmaynard
added
bug
harrism
approved these changes
May 30, 2023
|
Can you fix the cmake style failure, @robertmaynard ? |
robertmaynard
force-pushed
the
bug/logger_tests_mutually_exclusive
branch
from
40c65c6
to
8829878
Compare
|
I'll request an admin-merge here. |
bdice
added
5 - Ready to Merge
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
Corrects a bug introduced in #1277 which caused the logger tests to construct temporary directories in the build directory ( that never go deleted ). Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logger tests all read and write to the same temporary files so we extend the tests to generate temporary directories to write the files. This will ensure that concurrent execution of the logger test variants is supported.
Due to the current limitations of rapids-cmake in 23.06 we can't use the
SERIALorRESOURCE_LOCKfunctions of CTestto instead limit execution to be serial.
Checklist