Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure logger tests don't generate temp directories in build dir #1289

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Ensure logger tests don't generate temp directories in build dir #1289

merged 1 commit into from
Jun 9, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Corrects a bug introduced in #1277 which caused the logger tests to construct temporary directories in the build directory ( that never go deleted ).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Jun 6, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner June 6, 2023 19:07
@github-actions github-actions bot added the cpp Pertains to C++ code label Jun 6, 2023
@vyasr
Copy link
Contributor

vyasr commented Jun 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit b5203f2 into rapidsai:branch-23.08 Jun 9, 2023
37 checks passed
@robertmaynard robertmaynard deleted the bug/rmm_logger_test_cleanup branch June 12, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@vyasr vyasr vyasr approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for review Ready for review by team bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertmaynard @vyasr @harrism