Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding identify minimum version requirement #1301

Merged

Conversation

hyperbolic2346
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 commented Jul 17, 2023

Description

I ran into an issue with clang-format not being able to run due to the version of identify I had installed.

$ pre-commit 
An error has occurred: InvalidManifestError: 
==> At Hook(id='clang-format')
==> At key: types_or
==> At index 9
=====> Type tag 'textproto' is not recognized.  Try upgrading identify and pre-commit?

This led me to find out that pre-commit only requires version 1, but we require a newer version to work with clang-format. We don't specify that version anywhere, so I tracked down the minimum requirement and added it in our dependencies.yaml and ran pre-commit to update the conda environment files.

I verified that version 2.5.19 did not have textproto, but 2.5.20 did have it and that is why 2.5.20 is the minimum required version.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@hyperbolic2346 hyperbolic2346 requested a review from a team as a code owner July 17, 2023 23:24
@github-actions github-actions bot added the conda label Jul 17, 2023
@harrism harrism requested review from vyasr and bdice July 17, 2023 23:25
@vyasr vyasr added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 17, 2023
@harrism
Copy link
Member

harrism commented Jul 17, 2023

@vyasr or @bdice can you verify this?

@vyasr
Copy link
Contributor

vyasr commented Jul 18, 2023

@vyasr or @bdice can you verify this?

Yup, this is right. It'll be unblocked once #1302 merges.

@vyasr
Copy link
Contributor

vyasr commented Jul 18, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0a5b86c into rapidsai:branch-23.08 Jul 18, 2023
45 checks passed
@hyperbolic2346 hyperbolic2346 deleted the mwilson/identify_min_ver branch July 18, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants