Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linters: remove flake8, add ruff, update cython-lint #1302

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 17, 2023

Description

The cython-lint change is necessary to unblock runs after the Cython 3.0 update, but it is also a QOL improvement that allows us to remove flake8 usage in Cython files since cython-lint now covers a superset of what flake8 could do for Cython. ruff is (nearly) a superset of flake8 for pure Python and has a wide range of advantages, so this switch is beneficial as well.

cf. rapidsai/cudf#13699

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr self-assigned this Jul 17, 2023
@vyasr vyasr requested a review from a team as a code owner July 17, 2023 23:57
@vyasr vyasr added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 17, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Jul 18, 2023

/merge

@rapids-bot rapids-bot bot merged commit cfbc678 into rapidsai:branch-23.08 Jul 18, 2023
43 checks passed
@vyasr vyasr deleted the feat/ruff branch July 18, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants