Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ./build.sh flag to control CUDA async malloc support #901

Conversation

robertmaynard
Copy link
Contributor

This allows rmm to be built with CUDA 11.2 but removes the runtime requirement of CUDA 11.2+, allowing for execution
with older CUDA 11.X runtimes.

This allows rmm to be built with CUDA 11.2 but removes the
runtime requirement of CUDA 11.2+, allowing for execution
with older CUDA 11.X runtimes.
@robertmaynard robertmaynard added 3 - Ready for review Ready for review by team CMake conda non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 1, 2021
@robertmaynard robertmaynard requested review from a team as code owners November 1, 2021 18:48
@github-actions github-actions bot added cpp Pertains to C++ code Python Related to RMM Python API and removed conda labels Nov 1, 2021
build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
include/rmm/mr/device/cuda_async_memory_resource.hpp Outdated Show resolved Hide resolved
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one?

python/setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .hpp looks fine

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ef1981d into rapidsai:branch-21.12 Nov 3, 2021
@robertmaynard robertmaynard deleted the option_to_disable_async_support branch November 3, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team CMake cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants