Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly include cstdlib #13

Closed
Tracked by #38
stadlmax opened this issue Nov 30, 2022 · 0 comments · Fixed by #24
Closed
Tracked by #38

explicitly include cstdlib #13

stadlmax opened this issue Nov 30, 2022 · 0 comments · Fixed by #24
Assignees
@dongxuy04
Milestone
23.08

Comments

@stadlmax
Copy link
Contributor

The code contains abort() in few places without explicitly including the matching headers. With the Dockerfile given in this repository, this somehow does not cause any issues. To allow more straightforward builds from source in other environments, it might be better to explicitly import those headers, e.g. cstdlib.
@BradReesWork BradReesWork mentioned this issue Jul 10, 2023
Closed
@BradReesWork BradReesWork added this to the 23.08 milestone Jul 13, 2023
@BradReesWork BradReesWork mentioned this issue Jul 13, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #24 Jul 28, 2023
rapids-bot bot pushed a commit that referenced this issue Jul 28, 2023
@BradReesWork
Refactoring into 23.08 (#24)
aba3fd7 
This branch is a collection of all the refactoring improvements.  

closes #13 
closes #14 
closes #17 
closes #18 
closes rapidsai/cugraph-ops#492

Authors:
  - Brad Rees (https://github.com/BradReesWork)
  - https://github.com/dongxuy04
  - Junhong Liu (https://github.com/hello-11)
  - Tingyu Wang (https://github.com/tingyu66)

Approvers:
  - Tingyu Wang (https://github.com/tingyu66)
  - https://github.com/dongxuy04
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongxuy04 dongxuy04

Labels
None yet
Projects
None yet
Milestone
23.08
Development

Successfully merging a pull request may close this issue.

Refactoring into 23.08 rapidsai/wholegraph
3 participants
@BradReesWork @stadlmax @dongxuy04