Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all the GNN layer ops kernels with the corresponding APIs from cugraph-ops #17

Closed
Tracked by #38
teju85 opened this issue May 12, 2023 · 1 comment · Fixed by #24
Closed
Tracked by #38

Replace all the GNN layer ops kernels with the corresponding APIs from cugraph-ops #17

teju85 opened this issue May 12, 2023 · 1 comment · Fixed by #24
Assignees
@dongxuy04

Comments

@teju85
Copy link
Member

teju85 commented May 12, 2023

All (if not most) of the GNN layer ops in cugraph-ops should already help do the job, for which we have specific kernels in WholeGraph. Thus, there's lot of duplication of code between these 2 projects. We must further refactor WG GNN layer ops in order to use the ones from cugraph-ops instead of having to maintain specific kernels for these in WG.

  1. If not attempted already, please prepare a plan to replace these kernels with the corresponding calls from cugraph-ops in the next release cycle?
  2. If attempted, can you file issues against cugraphops for any missing features that are preventing this from happening?
@teju85 teju85 mentioned this issue May 12, 2023
Merged
@dongxuy04
Copy link
Contributor

@teju85 Have replaced GNN layer related ops with cugraph-ops from python level. Could you help check that and maybe we can close this issue? Thanks!

@BradReesWork BradReesWork mentioned this issue Jul 10, 2023
Closed
@BradReesWork BradReesWork mentioned this issue Jul 13, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #24 Jul 28, 2023
rapids-bot bot pushed a commit that referenced this issue Jul 28, 2023
@BradReesWork
Refactoring into 23.08 (#24)
aba3fd7 
This branch is a collection of all the refactoring improvements.  

closes #13 
closes #14 
closes #17 
closes #18 
closes rapidsai/cugraph-ops#492

Authors:
  - Brad Rees (https://github.com/BradReesWork)
  - https://github.com/dongxuy04
  - Junhong Liu (https://github.com/hello-11)
  - Tingyu Wang (https://github.com/tingyu66)

Approvers:
  - Tingyu Wang (https://github.com/tingyu66)
  - https://github.com/dongxuy04
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongxuy04 dongxuy04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring into 23.08 rapidsai/wholegraph
2 participants
@teju85 @dongxuy04