Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for DateColumn when empty #1726

Merged
merged 9 commits into from
May 30, 2024

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented May 30, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.54%. Comparing base (b114094) to head (cf479b9).
Report is 21 commits behind head on develop.

Current head cf479b9 differs from pull request most recent head 9b1f9f3

Please upload reports for the commit 9b1f9f3 to get more accurate results.

Files Patch % Lines
src/Commands/MakeCommand.php 0.00% 6 Missing ⚠️
src/Views/Columns/DateColumn.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1726      +/-   ##
=============================================
- Coverage      88.13%   86.54%   -1.59%     
- Complexity      1310     1349      +39     
=============================================
  Files            123      124       +1     
  Lines           3102     3197      +95     
=============================================
+ Hits            2734     2767      +33     
- Misses           368      430      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 1a15be7 into rappasoft:develop May 30, 2024
lrljoe added a commit that referenced this pull request Jun 5, 2024
* Fix ChangeLog, SP

* Filters - Set wire:model Method per-filter (#1699)


* Add wireableMethod tests 
---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Removing broken test (#1719)

* Scan provided path for all available FQCNs in paths within and outside app folder (#1714)

* Updated the make command to scan paths provided and check whether class of the model provided exists in the file.

This works with paths that are both within the app folder and outside such as vendor directory

---------

Co-authored-by: Marvin Ochieng <marvin@technologic-software.com>

* Add fix for DateColumn when empty (#1726)

* Add fix for DateColumn when empty


---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* PHPUnit - Migrate from Doc Comment Configuration (#1727)

* Migrate from Doc Comments to Attributes for PHPUnit

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add HTML render support for LinkColumn (#1728)

* Add the html render support for the LinkColumn

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Remove ChangeLog & SP Fixes

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Co-authored-by: marvoh <marvoh@protonmail.com>
Co-authored-by: Marvin Ochieng <marvin@technologic-software.com>
Co-authored-by: Abdul Haseeb Khan <abdulhaseebkhan407@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant