Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML render support for LinkColumn #1728

Merged
merged 21 commits into from
Jun 1, 2024
Merged

Conversation

code-creeper
Copy link
Contributor

This commit adds the ability to render HTML content in the titles of LinkColumns.

Previously, if a LinkColumn's title was set to an HTML string or a view file and the html() method was called, the HTML content was not rendered correctly. This update ensures that HTML titles are rendered properly when the html() method is used.

Key changes:

  • Updated the LinkColumn view file to handle HTML rendering in titles.
  • Update the docs/columns/available-methods.md.
  • Add the test cases.

This enhancement improves the flexibility and usability of LinkColumns, allowing for more dynamic and formatted link titles in data tables.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to ensure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

lrljoe and others added 20 commits November 3, 2023 16:02
Add Initial Lifecycle Hooks - Configuring/Configured by @lrljoe in v3 - Initial Lifecycle Hooks - Configuring/Configured rappasoft#1520
Add "HasAllTraits" for Maintainability by @lrljoe in v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes rappasoft#1514
Rename row-contents blades for clarity by @lrljoe in V3 Rename row-contents blades rappasoft#1519
Add missing tests for DateFilter and DateTimeFilter by @lrljoe in V3 Adds missing tests for DateTimeFilter and DateFilter rappasoft#1527
- Add additional Lifecycle Hook by @lrljoe in rappasoft#1534
  - SettingColumns/ColumnsSet
- Migrate methods for pre-render out of render by @lrljoe in rappasoft#1534
- Update tests to reflect hooks by @lrljoe in rappasoft#1534
- Update tests to add invalid string tests for dates by @lrljoe in rappasoft#1534
- Remove maps and minimise functions from FrontendAssets by @lrljoe in rappasoft#1534
Develop to Master - Workflows Only
## [v3.1.4] - 2023-12-04
### New Features
- Add capability to hide Column Label by @lrljoe in rappasoft#1512
- Add capability to set a custom script path for the scripts/styles by @lrljoe in rappasoft#1557
- Added rowsRetrieved Lifecycle Hook, expanded documentation for Lifecycle Hooks

### Bug Fixes
- Added missing tailwind background colour class for when hovering over the clear button in dark mode by @slakbal in rappasoft#1553
- Fixed extraneous space in config.php by @viliusvsx in in rappasoft#1577
- Changed table default vertical overflow to auto by @dmyers in rappasoft#1573
- Fix footer rendering issue with extra td displayed depending on bulk action statuses

### Tweaks
- Create additional Exception Classes (NoColumnsException, NoSearchableColumnsException, NoSortableColumnsException)
- Revert previous splitting of JS Files
- Add capability to customise Bulk Actions Styling with tests by @lrljoe in rappasoft#1564
  - TH Classes
  - TH Checkbox Classes
  - TD Classes
  - TD Checkbox Classes
@lrljoe lrljoe changed the base branch from master to develop June 1, 2024 02:29
@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Jun 1, 2024

I've changed the base to develop, and approved the workflow run. Once merged, future PRs won't need approval to run the workflows (but will still need core maintainer to merge in)

I will review this weekend, thank you very much for the PR! Really appreciate people helping keep this a great package.

Please do target develop for PRs going forward, as otherwise merge conflicts always occur, as we flatten the PRs from develop when going into master for a release!

@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Jun 1, 2024

You may need to update your fork with the latest "develop" branch updates to get the tests passing, as there's a broken test in "master" (which is fixed in develop).

Will re-merge into your master and see if that fixes the issue :)

@lrljoe lrljoe merged commit defe420 into rappasoft:develop Jun 1, 2024
7 checks passed
lrljoe added a commit that referenced this pull request Jun 5, 2024
* Fix ChangeLog, SP

* Filters - Set wire:model Method per-filter (#1699)


* Add wireableMethod tests 
---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Removing broken test (#1719)

* Scan provided path for all available FQCNs in paths within and outside app folder (#1714)

* Updated the make command to scan paths provided and check whether class of the model provided exists in the file.

This works with paths that are both within the app folder and outside such as vendor directory

---------

Co-authored-by: Marvin Ochieng <marvin@technologic-software.com>

* Add fix for DateColumn when empty (#1726)

* Add fix for DateColumn when empty


---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* PHPUnit - Migrate from Doc Comment Configuration (#1727)

* Migrate from Doc Comments to Attributes for PHPUnit

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Add HTML render support for LinkColumn (#1728)

* Add the html render support for the LinkColumn

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Remove ChangeLog & SP Fixes

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Co-authored-by: marvoh <marvoh@protonmail.com>
Co-authored-by: Marvin Ochieng <marvin@technologic-software.com>
Co-authored-by: Abdul Haseeb Khan <abdulhaseebkhan407@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants