Scan provided path for all available FQCNs in paths within and outside app folder #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Initial Lifecycle Hooks - Configuring/Configured by @lrljoe in v3 - Initial Lifecycle Hooks - Configuring/Configured rappasoft#1520 Add "HasAllTraits" for Maintainability by @lrljoe in v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes rappasoft#1514 Rename row-contents blades for clarity by @lrljoe in V3 Rename row-contents blades rappasoft#1519 Add missing tests for DateFilter and DateTimeFilter by @lrljoe in V3 Adds missing tests for DateTimeFilter and DateFilter rappasoft#1527
Update Changelog
Develop to Master 3.1.2
- Add additional Lifecycle Hook by @lrljoe in rappasoft#1534 - SettingColumns/ColumnsSet - Migrate methods for pre-render out of render by @lrljoe in rappasoft#1534 - Update tests to reflect hooks by @lrljoe in rappasoft#1534 - Update tests to add invalid string tests for dates by @lrljoe in rappasoft#1534 - Remove maps and minimise functions from FrontendAssets by @lrljoe in rappasoft#1534
Develop to Master - Workflows Only
V3 - Develop to Master (3.1.3)
## [v3.1.4] - 2023-12-04 ### New Features - Add capability to hide Column Label by @lrljoe in rappasoft#1512 - Add capability to set a custom script path for the scripts/styles by @lrljoe in rappasoft#1557 - Added rowsRetrieved Lifecycle Hook, expanded documentation for Lifecycle Hooks ### Bug Fixes - Added missing tailwind background colour class for when hovering over the clear button in dark mode by @slakbal in rappasoft#1553 - Fixed extraneous space in config.php by @viliusvsx in in rappasoft#1577 - Changed table default vertical overflow to auto by @dmyers in rappasoft#1573 - Fix footer rendering issue with extra td displayed depending on bulk action statuses ### Tweaks - Create additional Exception Classes (NoColumnsException, NoSearchableColumnsException, NoSortableColumnsException) - Revert previous splitting of JS Files - Add capability to customise Bulk Actions Styling with tests by @lrljoe in rappasoft#1564 - TH Classes - TH Checkbox Classes - TD Classes - TD Checkbox Classes
Pre 3.1.5 release merge
Develop to Master
3.1.7 Develop to Master
v3.1.8 - Release
…#1621) * Fix CHANGELOG.md missing release
V3.2.1 Release
v3.2.2 Release
V3.2.3 Pre-Release Merge (rappasoft#1675)
…ss of the model provided exists in the file. This works with paths that are both within the app folder and outside such as vendor directory
|
So will definitely review this in the next week. Typically I've seen people extending a Vendor Model, rather than directly referencing it, but happy to adjust the Make Command to allow for this. Not sure whether your PR is causing the test failures, or something else is going on behind the scenes though, your PR shouldn't be breaking pagination from looking at what's changed. |
|
The breakages are strange also to me. I can stick to best practise and extend the models instead? |
|
Can you resolve the conflict in CHANGELOG.md, and let's see if the tests re-run and pass, as they seem to be mostly passing locally (I had one error when running it in a test environment) |
|
Think something's changed in core that is causing the test to fail, will disable that test this weekend, and once changelog is updated, it should be mergeable. |
|
This will be in the next release (should be this weekend). |
lrljoe
added a commit
that referenced
this pull request
Jun 5, 2024
* Fix ChangeLog, SP * Filters - Set wire:model Method per-filter (#1699) * Add wireableMethod tests --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Removing broken test (#1719) * Scan provided path for all available FQCNs in paths within and outside app folder (#1714) * Updated the make command to scan paths provided and check whether class of the model provided exists in the file. This works with paths that are both within the app folder and outside such as vendor directory --------- Co-authored-by: Marvin Ochieng <marvin@technologic-software.com> * Add fix for DateColumn when empty (#1726) * Add fix for DateColumn when empty --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * PHPUnit - Migrate from Doc Comment Configuration (#1727) * Migrate from Doc Comments to Attributes for PHPUnit --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Add HTML render support for LinkColumn (#1728) * Add the html render support for the LinkColumn --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Remove ChangeLog & SP Fixes --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> Co-authored-by: marvoh <marvoh@protonmail.com> Co-authored-by: Marvin Ochieng <marvin@technologic-software.com> Co-authored-by: Abdul Haseeb Khan <abdulhaseebkhan407@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we work on newer projects, we find that the scope of functionality begins to become repetitive and therefore you or someone else may have already done some piece of work that you already need. These would typically be installed in the vendors folder through composer.
Some of these packages have models which the user of the end product would need to interact with therefore will require presentation in tables. However, this package at the moment does not accept packages outside app path.
If time permits and resources permits, please consider looking into supporting both scenarios.