Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split doesn't memoize on Signal[LazyList[A]] #117

Closed
mattjacobus opened this issue Feb 7, 2024 · 2 comments
Closed

split doesn't memoize on Signal[LazyList[A]] #117

mattjacobus opened this issue Feb 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mattjacobus
Copy link

SplitSignal uses side effects in a map over the elements to keep track of which keys have been seen and since the LazyList is evaluated later, it believes no keys were seen and purges all the child signals and calls your project function on every event. You might want another implicit specifically for LazyLists that does a force.

@raquo
Copy link
Owner

raquo commented Feb 7, 2024

Thanks, good find! Somehow I've never used LazyList...

I think I'll update the map method of ImmutableSeqSplittable to do something special if the input is a LazyList. Probably convert it to a strict Seq like List or ArraySeq.

@raquo raquo added the bug Something isn't working label Feb 7, 2024
@raquo
Copy link
Owner

raquo commented Jun 26, 2024

This was fixed in 17.0.0, forgot to close earlier.

@raquo raquo closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants