-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATO-2105] Implement functionality to create custom spans #1075
Conversation
7f0b4f2
to
fc7c476
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💯 In addition to the below comments, how did you obtain that view in Jaeger? I'd suggest to add a new test custom action that does the same steps you took to get that custom span in a different test case.
It will require an integration test to achieve this. I wrote a custom action like this and triggered it
|
a63db04
to
c28a929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I'd also make Sanchari aware of this integration test case need to be added to the list for the action server testing.
Proposed changes:
Views from Jaegar UI
Status (please check what you already did):
black
(please check Readme for instructions)