Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ATO-2103] Instrument FormValidationAction._extract_validation_events #1077

Merged
merged 4 commits into from
Feb 20, 2024
Merged

[ATO-2103] Instrument FormValidationAction._extract_validation_events #1077

merged 4 commits into from
Feb 20, 2024

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Feb 19, 2024 •
edited by jira bot
Loading

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt force-pushed the ATO-2103-instrument-FormValidationAction._extract_validation_events branch 6 times, most recently from 5b4163d to 21f4adf Compare February 19, 2024 15:54
@Tawakalt Tawakalt force-pushed the ATO-2103-instrument-FormValidationAction._extract_validation_events branch from 21f4adf to a5df827 Compare February 19, 2024 15:59
ancalita
ancalita reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 I left a few comments regarding the tests.

tests/tracing/instrumentation/test_form_validation_action.py Show resolved Hide resolved
tests/tracing/instrumentation/test_form_validation_action.py Outdated Show resolved Hide resolved
tests/tracing/instrumentation/test_validation_action.py Outdated Show resolved Hide resolved
ancalita
ancalita approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍🏻 I left one minor comment on optimizing the imports.

rasa_sdk/tracing/instrumentation/instrumentation.py Outdated Show resolved Hide resolved
@Tawakalt Tawakalt force-pushed the ATO-2103-instrument-FormValidationAction._extract_validation_events branch from 96e8639 to 630bdfb Compare February 20, 2024 12:02
@Tawakalt Tawakalt force-pushed the ATO-2103-instrument-FormValidationAction._extract_validation_events branch from 630bdfb to 7bafea3 Compare February 20, 2024 12:07
@Tawakalt Tawakalt merged commit 93104bf into main Feb 20, 2024
16 checks passed
@Tawakalt Tawakalt deleted the ATO-2103-instrument-FormValidationAction._extract_validation_events branch February 20, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tawakalt @ancalita