-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate: deprecate NLU JSON format #10989
Conversation
NLU data in JSON format is deprecated and will be removed in Rasa Open Source 4.0. Refs: ATO-26
86670c0
to
4f30454
Compare
🚀 A preview of the docs have been deployed at the following URL: https://10989--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏼
Left some questions regarding the deprecation of the command itself.
### NLU JSON Format | ||
|
||
[NLU training data](nlu-training-data.mdx) in JSON format is deprecated and will be | ||
removed in Rasa Open Source 4.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add that the command will be removed too in 4.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still support the convert command for users migration from LUIS/Watson/Dialogflow, don't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I realized that we don't support that at the moment but might support that in the future #7935 . I'd slightly lean to not deprecate the entire rasa data convert
command for now (cc @chandrikas) but rather just this specific conversion path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused as in the meeting I thought the consensus was towards removing the command, but your point makes sense.
NLU data in JSON format is deprecated and will be removed in Rasa Open Source 4.0. Refs: ATO-26
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)