Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: deprecate NLU JSON format #10989

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

wochinge
Copy link
Contributor

Proposed changes:

  • NLU data in JSON format is deprecated and will be removed in Rasa Open Source 4.0.
  • fix ATO-26

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from a team as a code owner March 14, 2022 14:11
@wochinge wochinge requested review from chandrikas and removed request for a team March 14, 2022 14:11
NLU data in JSON format is deprecated and will be removed in Rasa Open Source 4.0.

Refs: ATO-26
@wochinge wochinge force-pushed the ATO-26-deprecate-json-to-yaml-conversion branch from 86670c0 to 4f30454 Compare March 14, 2022 14:12
@wochinge wochinge requested review from ancalita and a team and removed request for a team March 14, 2022 14:13
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://10989--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼
Left some questions regarding the deprecation of the command itself.

### NLU JSON Format

[NLU training data](nlu-training-data.mdx) in JSON format is deprecated and will be
removed in Rasa Open Source 4.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add that the command will be removed too in 4.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still support the convert command for users migration from LUIS/Watson/Dialogflow, don't we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I realized that we don't support that at the moment but might support that in the future #7935 . I'd slightly lean to not deprecate the entire rasa data convert command for now (cc @chandrikas) but rather just this specific conversion path

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused as in the meeting I thought the consensus was towards removing the command, but your point makes sense.

rasa/shared/nlu/training_data/formats/rasa.py Show resolved Hide resolved
@wochinge wochinge merged commit 0f01871 into main Mar 15, 2022
@wochinge wochinge deleted the ATO-26-deprecate-json-to-yaml-conversion branch March 15, 2022 12:05
indam23 pushed a commit that referenced this pull request Jul 27, 2022
NLU data in JSON format is deprecated and will be removed in Rasa Open Source 4.0.

Refs: ATO-26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants