Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs rasa x #11156

Merged
merged 5 commits into from
May 31, 2022
Merged

Update docs rasa x #11156

merged 5 commits into from
May 31, 2022

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented May 30, 2022 •
edited
Loading

Proposed changes:

  • Fixes https://rasahq.atlassian.net/browse/ATO-125
  • Rename "Rasa X" to "Rasa Enteprise" in docs, and remove sections that do not make sense anymore
  • Cleanup mentions of "Rasa X" in the code base
  • rasa --version does not print Rasa X Version anymore

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@m-vdb m-vdb marked this pull request as ready for review May 30, 2022 10:06
@m-vdb m-vdb requested a review from a team as a code owner May 30, 2022 10:06
@m-vdb m-vdb requested review from losterloh and alexweidauer and removed request for a team May 30, 2022 10:06
@m-vdb
Copy link
Collaborator Author

m-vdb commented May 30, 2022

@alexweidauer could you review the documentation changes that I made in this PR for Rasa OSS?
@losterloh feel free to also take a look at the documentation changes if you want, but I'll need your review on anything that is not under the docs/ folder 😄

Thanks 🙏🏻

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11156--rasahq-docs-rasa-v2.netlify.app/docs/rasa

alexweidauer
alexweidauer approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@alexweidauer alexweidauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maxime! The changes look great.

@m-vdb m-vdb requested review from ancalita and removed request for losterloh May 31, 2022 12:56
@m-vdb m-vdb merged commit b63715a into 3.1.x May 31, 2022
@m-vdb m-vdb deleted the update-docs-rasa-x branch May 31, 2022 14:40
This was referenced Jun 3, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexweidauer alexweidauer alexweidauer approved these changes

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-vdb @alexweidauer @ancalita