Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vulnerable dependencies in 2.8.x #11252

Merged
merged 5 commits into from
Jun 22, 2022
Merged

Update vulnerable dependencies in 2.8.x #11252

merged 5 commits into from
Jun 22, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Jun 22, 2022 •
edited
Loading

Proposed changes:

  • Update vulnerable dependencies in 2.8.x
  • Upgrade of Sanic resulted in tests failing with the same error described here, setting Sanic app instance register parameter to False fixes this issue.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita changed the title poetry update with pinned spacy Update vulnerable dependencies in 2.8.x Jun 22, 2022
@virtualroot virtualroot marked this pull request as ready for review June 22, 2022 12:27
@ancalita ancalita requested a review from indam23 June 22, 2022 14:34
indam23
indam23 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find on the sanic issue, I ran into it today as well via dependabot and was mighty puzzled

@ancalita ancalita enabled auto-merge (squash) June 22, 2022 15:14
@ancalita ancalita merged commit 7f736e6 into 2.8.x Jun 22, 2022
@ancalita ancalita deleted the ATO-203-2.8.x-update branch June 22, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virtualroot virtualroot virtualroot approved these changes

@indam23 indam23 indam23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ancalita @virtualroot @indam23