Fix ValidationAction dispatching of BotUttered messages
#11394
Conversation
ancalita
requested review from
sanchariGr,
indam23 and
losterloh
and removed request for
a team
rasa/core/processor.py
Outdated
| @@ -180,6 +180,8 @@ async def run_action_extract_slots( | |||
| f"Default action '{ACTION_EXTRACT_SLOTS}' was executed, " | |||
| f"resulting in {len(extraction_events)} events: {events_as_str}" | |||
| ) | |||
| await self.execute_side_effects(extraction_events, tracker, output_channel) | |||
There was a problem hiding this comment.
I see that the other side effects are scheduling / cancelling reminders - do you know if the behaviour for either of those now changes?
Is it possible to include unit tests for the expected behaviour of those two, once we know what it is?
There was a problem hiding this comment.
Good question, I should only apply the first side-effect (sending bot messages), since the other events are disallowed during validation (only SlotSet and BotUttered are allowed event types to be returned during slot validation, see here).
There was a problem hiding this comment.
Gotcha, that makes sense.
One thing I am confused by, why do users want to return BotUttered events instead of returning responses directly? Or is this different for slot validation than for other custom actions?
There was a problem hiding this comment.
why do users want to return BotUttered events instead of returning responses directly?
You mean why wouldn't they use dispatcher.utter_message instead of returning the BotUttered event? Not sure 😄 It seems both approaches are valid, so we wanted to enable that.
|
🚀 A preview of the docs have been deployed at the following URL: https://11394--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Proposed changes:
dispatcher.utter_messagein a slot validation action does not display in a conversation rasa-sdk#612 (more context in the discussion here)Status (please check what you already did):
black(please check Readme for instructions)