Export events continuously rather than loading all events in memory first #11623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
requested review from
znat,
ancalita and
a team
and removed request for
a team
ancalita
reviewed
Oct 7, 2022
Comment on lines
-317
to
-320
| if not events: | ||
| raise NoEventsInTimeRangeError( | ||
| "Could not find any events within requested time range. Exiting." | ||
| ) |
There was a problem hiding this comment.
Should we retain raising this exception if published_events == 0 in publish_events() after going through generator results?
There was a problem hiding this comment.
I don't think this is helpful tbh. There is output on how many events got produced and that will just be 0 in this case. but happy to readd it
There was a problem hiding this comment.
Makes sense! I asked in case this exception is handled maybe in some custom way either in the codebase already or in a customer's project, that could have required further amendments.
|
🚀 A preview of the docs have been deployed at the following URL: https://11623--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
ancalita
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Fixes https://rasahq.atlassian.net/browse/ATO-441