Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "exact" recommendation to permutation test #722

Open
rasbt opened this issue Aug 20, 2020 · 1 comment
Open

Add "exact" recommendation to permutation test #722

rasbt opened this issue Aug 20, 2020 · 1 comment

Comments

@rasbt
Copy link
Owner

rasbt commented Aug 20, 2020

As described in #721

The [permutation_test] function could raise a warning if the user wants to run a number of simulations that is close (> 50% ?) to the total number of possible combinations, so that they can switch to the exact method in that case.

@pkaf
Copy link

pkaf commented Sep 23, 2020

This would be a rare case no? Even for a m + n = 100 and m = 50, the total number of combinations would be massive.
However, I see in a case of m<<100 there is a room for an improvement. Am I understanding this problem correctly?

I am happy to raise ValueError(?) there if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants