Revert downstream wm8804 changes #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@francesco-vannini any chance you could test this? Or @mmilann ?
…On 2 Feb 2018 12:21 p.m., "Matthias Reichl" ***@***.***> wrote:
It looks like the changes to the wm8804 codec that we have here in the rpi
tree come from a time where the i2s driver didn't support mmap and hacking
in 32bit support (which isn't supported by the codec and breaks 24-bit
support) was used as a workaround. Not exactly sure why idle_bias_off was
changed, but that smells rather suspicously like a workaround, too.
I've successfully tested the Hifiberry Digi Pro, Justboom Digi and Cirrus
Logic Audio Card with the local changes reverted.
ping @hifiberry <https://github.com/hifiberry> @shawaj
<https://github.com/shawaj> could you test with this PR as well?
------------------------------
You can view, comment on, or merge this pull request online at:
#2364
Commit Summary
- Revert downstream wm8804 changes
File Changes
- *M* sound/soc/codecs/wm8804.c
<https://github.com/raspberrypi/linux/pull/2364/files#diff-0> (5)
Patch Links:
- https://github.com/raspberrypi/linux/pull/2364.patch
- https://github.com/raspberrypi/linux/pull/2364.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2364>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADNCukCbSKJUKBFWeNeDiU_9k7rtXScFks5tQv3cgaJpZM4R3Gyb>
.
|
|
not until I am back I'm afraid but I can mid next week if that's OK |
|
@HiassofT we're certainly keen to drop downstream patches if they are no longer required. |
popcornmix
force-pushed
the
rpi-4.14.y
branch
3 times, most recently
from
7465564
to
47efcbd
Compare
HiassofT
force-pushed
the
4.14-revert-wm8804-changes
branch
from
e5bc564
to
30b6321
Compare
|
rebased onto current rpi-4.14.y tree and added Signed-off-by |
|
@francesco-vannini sure, here's a precompiled RPi2 kernel: |
popcornmix
force-pushed
the
rpi-4.14.y
branch
from
048970d
to
90ac037
Compare
The format change from S24_LE to S24_3LE effectively disables 24-bit mode as S24_3LE isn't supported by bcm2835-i2s. This causes issues with drivers that want to use wm8804 in 24-bit mode. Adding the S32_LE format is also incorrect, according to the datasheet only 16-24 bit formats are supported. Signed-off-by: Matthias Reichl <hias@horus.com>
HiassofT
force-pushed
the
4.14-revert-wm8804-changes
branch
from
30b6321
to
6ed6d9d
Compare
|
Is there any feedback on this PR? |
|
@francesco-vannini commented here #2365 (comment) that this PR seems to be fine
|
|
Sorry @pelwell , in the excitement of having actually been able to do the compilation and all I forgot to update you with a comment here ;) |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 20, 2018
kernel: Add support for SuperAudioBoard sound card (#2386) See: raspberrypi/linux#2386 kernel: Revert downstream wm8804 changes See: raspberrypi/linux#2364 kernel: Generic Rotary Encoder overlay for multiple instances (#2388) See: raspberrypi/linux#2388 kernel: dwc_otg: Fix a regression when dequeueing isochronous transfers See: raspberrypi/linux#2380 kernel: dwc_otg: add smp_mb() to prevent driver state corruption on boot See: raspberrypi/linux#2382 kernel: overlays: Allow multiple instances of gpio-ir[-tx] kernel: overlay: Add missing pinctrl reference to gpio-ir kernel: properly fix S24_LE mode with pcm512x codec See: raspberrypi/linux#2365
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Feb 20, 2018
kernel: Add support for SuperAudioBoard sound card (#2386) See: raspberrypi/linux#2386 kernel: Revert downstream wm8804 changes See: raspberrypi/linux#2364 kernel: Generic Rotary Encoder overlay for multiple instances (#2388) See: raspberrypi/linux#2388 kernel: dwc_otg: Fix a regression when dequeueing isochronous transfers See: raspberrypi/linux#2380 kernel: dwc_otg: add smp_mb() to prevent driver state corruption on boot See: raspberrypi/linux#2382 kernel: overlays: Allow multiple instances of gpio-ir[-tx] kernel: overlay: Add missing pinctrl reference to gpio-ir kernel: properly fix S24_LE mode with pcm512x codec See: raspberrypi/linux#2365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the changes to the wm8804 codec that we have here in the rpi tree come from a time where the i2s driver didn't support mmap and hacking in 32bit support (which isn't supported by the codec and breaks 24-bit support) was used as a workaround. Not exactly sure why idle_bias_off was changed, but that smells rather suspicously like a workaround, too.
I've successfully tested the Hifiberry Digi Pro, Justboom Digi and Cirrus Logic Audio Card with the local changes reverted.
ping @hifiberry @shawaj could you test with this PR as well?