dwc_otg: Fix a regression when dequeueing isochronous transfers #2380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 282bed9 (dwc_otg: make nak_holdoff work as intended with empty queues) the dequeue mechanism was changed to leave FIQ-enabled transfers to run to completion - to avoid leaving hub TT buffers with stale packets lying around. This broke FIQ-accelerated isochronous transfers, as this then meant that dozens of transfers were performed after the dequeue function returned. Restore the state machine fence for isochronous transfers.
|
c.f. #2363 |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 20, 2018
kernel: Add support for SuperAudioBoard sound card (#2386) See: raspberrypi/linux#2386 kernel: Revert downstream wm8804 changes See: raspberrypi/linux#2364 kernel: Generic Rotary Encoder overlay for multiple instances (#2388) See: raspberrypi/linux#2388 kernel: dwc_otg: Fix a regression when dequeueing isochronous transfers See: raspberrypi/linux#2380 kernel: dwc_otg: add smp_mb() to prevent driver state corruption on boot See: raspberrypi/linux#2382 kernel: overlays: Allow multiple instances of gpio-ir[-tx] kernel: overlay: Add missing pinctrl reference to gpio-ir kernel: properly fix S24_LE mode with pcm512x codec See: raspberrypi/linux#2365
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Feb 20, 2018
kernel: Add support for SuperAudioBoard sound card (#2386) See: raspberrypi/linux#2386 kernel: Revert downstream wm8804 changes See: raspberrypi/linux#2364 kernel: Generic Rotary Encoder overlay for multiple instances (#2388) See: raspberrypi/linux#2388 kernel: dwc_otg: Fix a regression when dequeueing isochronous transfers See: raspberrypi/linux#2380 kernel: dwc_otg: add smp_mb() to prevent driver state corruption on boot See: raspberrypi/linux#2382 kernel: overlays: Allow multiple instances of gpio-ir[-tx] kernel: overlay: Add missing pinctrl reference to gpio-ir kernel: properly fix S24_LE mode with pcm512x codec See: raspberrypi/linux#2365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 282bed9 (dwc_otg: make nak_holdoff work as intended with empty queues)
the dequeue mechanism was changed to leave FIQ-enabled transfers to run
to completion - to avoid leaving hub TT buffers with stale packets lying
around.
This broke FIQ-accelerated isochronous transfers, as this then meant that
dozens of transfers were performed after the dequeue function returned.
Restore the state machine fence for isochronous transfers.