dwc_otg: add smp_mb() to prevent driver state corruption on boot #2382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasional crashes have been seen where the FIQ code dereferences invalid/random pointers immediately after being set up, leading to panic on boot. The crash occurs as the FIQ code races against hcd_init_fiq() and the hcd_init_fiq() code races against the outstanding memory stores from dwc_otg_hcd_init(). Use explicit barriers after touching driver state.
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 20, 2018
kernel: Add support for SuperAudioBoard sound card (#2386) See: raspberrypi/linux#2386 kernel: Revert downstream wm8804 changes See: raspberrypi/linux#2364 kernel: Generic Rotary Encoder overlay for multiple instances (#2388) See: raspberrypi/linux#2388 kernel: dwc_otg: Fix a regression when dequeueing isochronous transfers See: raspberrypi/linux#2380 kernel: dwc_otg: add smp_mb() to prevent driver state corruption on boot See: raspberrypi/linux#2382 kernel: overlays: Allow multiple instances of gpio-ir[-tx] kernel: overlay: Add missing pinctrl reference to gpio-ir kernel: properly fix S24_LE mode with pcm512x codec See: raspberrypi/linux#2365
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Feb 20, 2018
kernel: Add support for SuperAudioBoard sound card (#2386) See: raspberrypi/linux#2386 kernel: Revert downstream wm8804 changes See: raspberrypi/linux#2364 kernel: Generic Rotary Encoder overlay for multiple instances (#2388) See: raspberrypi/linux#2388 kernel: dwc_otg: Fix a regression when dequeueing isochronous transfers See: raspberrypi/linux#2380 kernel: dwc_otg: add smp_mb() to prevent driver state corruption on boot See: raspberrypi/linux#2382 kernel: overlays: Allow multiple instances of gpio-ir[-tx] kernel: overlay: Add missing pinctrl reference to gpio-ir kernel: properly fix S24_LE mode with pcm512x codec See: raspberrypi/linux#2365
ailispaw
added a commit
to bargees/barge-os
that referenced
this pull request
Mar 8, 2018
ailispaw
added a commit
to bargees/barge-os
that referenced
this pull request
Mar 9, 2018
ailispaw
added a commit
to bargees/barge-os
that referenced
this pull request
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasional crashes have been seen where the FIQ code dereferences
invalid/random pointers immediately after being set up, leading to
panic on boot.
The crash occurs as the FIQ code races against hcd_init_fiq() and
the hcd_init_fiq() code races against the outstanding memory stores
from dwc_otg_hcd_init(). Use explicit barriers after touching
driver state.
Ref.
https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=197689&start=50#p1272920
https://www.raspberrypi.org/forums/viewtopic.php?f=53&p=1271589#p1263432