overlays: seeed-can-fd-hat: clarify how to identify HAT version #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the used CAN SPI chip is not a good way to identify the version of the CAN HAT. There are two different board layouts of the Seeed Studio CAN BUS FD HAT. The v1 board doesn't have a battery holder, while the v2 board has. Update the overlay README accordinly. Link: Seeed-Studio/seeed-linux-dtoverlays#13 Cc: Patrick Menschel <menschel.p@posteo.de> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
|
Wow - that was quick! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 15, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jan 15, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 16, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 16, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 16, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 18, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 19, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 20, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 20, 2021
kernel: overlays: seeed-can-fd-hat: clarify how to identify HAT version See: raspberrypi/linux#4072 kernel: Add a camera regulator node(s) to allow sharing on CM4 and remove firmware nastiness See: raspberrypi/linux#4051 firmware: isp: Fix handling of different YUV colour spaces firmware: poe_hat: Actually close the I2C handle Signed-off-by: Christian Stewart <christian@paral.in>
bigbearishappy
added a commit
to Seeed-Studio/seeed-linux-dtoverlays
that referenced
this pull request
Apr 13, 2022
Why delete? Because the CAN-HAT driver is already merged into the main line of raspberrypi kernel. raspberrypi/linux#4072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the used CAN SPI chip is not a good way to identify the version of
the CAN HAT.
There are two different board layouts of the Seeed Studio CAN BUS FD HAT. The
v1 board doesn't have a battery holder, while the v2 board has. Update the
overlay README accordingly.
Link: Seeed-Studio/seeed-linux-dtoverlays#13
Cc: Patrick Menschel menschel.p@posteo.de
Signed-off-by: Marc Kleine-Budde mkl@pengutronix.de