Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imx477 long exposure control #4150

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

naushir
Copy link
Contributor

@naushir naushir commented Feb 16, 2021

No description provided.

The V4L2_CID_EXPOSURE_AUTO_PRIORITY was used to let the sensor control
frame length (effectively framerate) based on the requested exposure
time requested. Remove this feature as it is never used, and goes
against how V4L2 likes to handle exposure and vblank controls.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
drivers/media/i2c/imx477.c Outdated Show resolved Hide resolved
drivers/media/i2c/imx477.c Outdated Show resolved Hide resolved
drivers/media/i2c/imx477.c Outdated Show resolved Hide resolved
drivers/media/i2c/imx477.c Outdated Show resolved Hide resolved
drivers/media/i2c/imx477.c Outdated Show resolved Hide resolved
Add support for very long exposures by using the exposure multiplier
register. Userland does not need to pass any additional controls to
enable long exposures, it simply requests a larger vblank to extend the
exposure control range appropriately.

Currently, since hblank is fixed, a maximum of approximately 124 seconds
of exposure time can be used. In a future change, hblank could also be
controlled in userland to give over 200 seconds of exposure time.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
@naushir
Copy link
Contributor Author

naushir commented Feb 18, 2021

@pelwell and @6by9 this is ready to go in if you are both happy.

@pelwell pelwell merged commit b8dc11c into raspberrypi:rpi-5.10.y Feb 18, 2021
@naushir naushir deleted the imx477_long_exposure branch February 18, 2021 13:38
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Feb 22, 2021
kernel: PiFi DAC overlays
See: raspberrypi/linux#4154

kernel: staging: rpivid: Fix crash when CMA alloc fails
See: raspberrypi/linux#4152

kernel: Imx477 long exposure control
See: raspberrypi/linux#4150

kernel: configs: Change CONFIG_BLK_DEV_NVME=y for 2711
See: raspberrypi/linux#4164

kernel: Some fixes to make imx290/imx327 exposure and vblank updates work correctly
See: raspberrypi/linux#4153

kernel: KMS VGA666 overlay
See: raspberrypi/linux#4141

kernel: gpio-fsm: Fix shutdown timeout handling

kernel: configs: Add various missing IPV6 modules
See: raspberrypi/linux#4144
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Feb 22, 2021
kernel: PiFi DAC overlays
See: raspberrypi/linux#4154

kernel: staging: rpivid: Fix crash when CMA alloc fails
See: raspberrypi/linux#4152

kernel: Imx477 long exposure control
See: raspberrypi/linux#4150

kernel: configs: Change CONFIG_BLK_DEV_NVME=y for 2711
See: raspberrypi/linux#4164

kernel: Some fixes to make imx290/imx327 exposure and vblank updates work correctly
See: raspberrypi/linux#4153

kernel: KMS VGA666 overlay
See: raspberrypi/linux#4141

kernel: gpio-fsm: Fix shutdown timeout handling

kernel: configs: Add various missing IPV6 modules
See: raspberrypi/linux#4144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants