DAC overlays #4154

pifi-bz · 2021-02-18T17:54:27Z

as discussed.

Signed-off-by: David Knell <david.knell@gmail.com>

pelwell

I got my wish with finding something to comment on, but it's all minor stuff.

pelwell · 2021-02-18T21:09:40Z

arch/arm/boot/dts/overlays/Makefile

@@ -130,6 +130,8 @@ dtbo-$(CONFIG_ARCH_BCM2835) += \
 	pibell.dtbo \
 	pifacedigital.dtbo \
 	pifi-40.dtbo \
+	pifi-dac-zero.dtbo \
+	pifi-dac-hd.dtbo \


Alphabetical order, please.

pelwell · 2021-02-18T21:09:58Z

arch/arm/boot/dts/overlays/README

+Params: <None>
+
+
+Name:   pifi-dac-hd


Order again.

pelwell · 2021-02-18T21:10:45Z

arch/arm/boot/dts/overlays/pifi-dac-hd-overlay.dts

+/plugin/;
+
+/ {
+	compatible = "brcm,bcm2708";


Please use "brcm,bcm2835".

pelwell · 2021-02-18T21:13:12Z

arch/arm/boot/dts/overlays/pifi-dac-hd-overlay.dts

+			simple-audio-card,name = "PiFi-DAC-HD";
+			status="okay";
+
+			playback_link: simple-audio-card,dai-link@1 {


FYI, if nothing references a label (e.g. &playback_link) in an overlay and it isn't exported then it serves no purpose. The same goes for p_cpu_dai and p_codec_dai.

pelwell · 2021-02-18T21:14:04Z

arch/arm/boot/dts/overlays/pifi-dac-hd-overlay.dts

+		__overlay__ {
+			compatible = "simple-audio-card";
+			simple-audio-card,name = "PiFi-DAC-HD";
+			status="okay";


It's a bit picky, but the rest of the overlay is so nicely formatted that the lack of spaces here stands out.

pelwell · 2021-02-18T21:14:55Z

arch/arm/boot/dts/overlays/pifi-dac-zero-overlay.dts

+
+            status = "okay";
+
+            playback_link: simple-audio-card,dai-link@1 {


Same comment about unused labels.

pelwell · 2021-02-18T21:17:46Z

arch/arm/boot/dts/overlays/pifi-dac-hd-overlay.dts

+		target = <&i2s>;
+		__overlay__ {
+			status = "okay";
+        };


This line looks like a mixture of spaces and TABs - not a crime (unlike in the README), just a bit ugly.

pifi-bz · 2021-02-19T10:07:01Z

Ooh dear. These should be all tidied up in the latest commit - are you OK with said commit being added to this pull request, or should I redo from start (as my Commodore PET used to say..)

pelwell · 2021-02-19T10:16:33Z

If you are creating these commit in the GitHub GUI then do it any way you like and I'll squash them all. If you're creating the PRs on the command line and pushing them then the general way to update a PR is:

Add a new commit with the changes. If the PR has multiple commits and you want to change more than one then split your changes across as many new commits. git add -p is useful for selectively staging changes in preparation for creating commits out of some of them.
Use git rebase -i HEAD~<n>, where <n> is the number of commits at the top of the branch that should be considered for the PR. Having an <n> that is too large normally just slows things down, but it gets ugly if one of the extras is a merge commit...
Use git push -f origin HEAD:<remote-branch-name> to update the PR.

Signed-off-by: David Knell <david.knell@gmail.com>

pifi-bz · 2021-02-19T10:39:14Z

How's that?

pelwell · 2021-02-19T10:52:32Z

arch/arm/boot/dts/overlays/pifi-dac-hd-overlay.dts

@@ -3,23 +3,23 @@
 /plugin/;

 / {
-	compatible = "brcm,bcm2708";
+	compatible = "brcm,bcm2735";


Oooh - so close.

Ouch. Thank you, again, for your patience.

Signed-off-by: David Knell <david.knell@gmail.com>

kernel: PiFi DAC overlays See: raspberrypi/linux#4154 kernel: staging: rpivid: Fix crash when CMA alloc fails See: raspberrypi/linux#4152 kernel: Imx477 long exposure control See: raspberrypi/linux#4150 kernel: configs: Change CONFIG_BLK_DEV_NVME=y for 2711 See: raspberrypi/linux#4164 kernel: Some fixes to make imx290/imx327 exposure and vblank updates work correctly See: raspberrypi/linux#4153 kernel: KMS VGA666 overlay See: raspberrypi/linux#4141 kernel: gpio-fsm: Fix shutdown timeout handling kernel: configs: Add various missing IPV6 modules See: raspberrypi/linux#4144

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

DaveKnell added 2 commits February 18, 2021 14:05

PiFi DAC Zero overlay

c31386f

Signed-off-by: David Knell <david.knell@gmail.com>

PiFi DAC HD overlay

1fee8d0

Signed-off-by: David Knell <david.knell@gmail.com>

pelwell reviewed Feb 18, 2021

View reviewed changes

pifi-bz force-pushed the rpi-5.10.y branch from b8b8e95 to 1fee8d0 Compare February 19, 2021 10:33

DaveKnell added 3 commits February 19, 2021 10:35

Makefile/README in order

9d6bc46

Signed-off-by: David Knell <david.knell@gmail.com>

PiFi DAC Zero overlay tidied up

26fe38d

Signed-off-by: David Knell <david.knell@gmail.com>

PiFi DAC HD overlay tidied up

8a273b1

Signed-off-by: David Knell <david.knell@gmail.com>

pelwell reviewed Feb 19, 2021

View reviewed changes

Imaginary processor replaced with real one

863c057

Signed-off-by: David Knell <david.knell@gmail.com>

pelwell merged commit 7f09832 into raspberrypi:rpi-5.10.y Feb 19, 2021

pelwell pushed a commit that referenced this pull request Feb 23, 2021

DAC overlays (#4154)

14a6364

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request Mar 16, 2021

DAC overlays (#4154)

f829095

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request Mar 22, 2021

DAC overlays (#4154)

62f94bd

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request Mar 29, 2021

DAC overlays (#4154)

e6af522

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request Apr 6, 2021

DAC overlays (#4154)

4785f70

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request Apr 19, 2021

DAC overlays (#4154)

a9dfe0e

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request Apr 27, 2021

DAC overlays (#4154)

f75d513

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request Apr 30, 2021

DAC overlays (#4154)

0062ee9

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request May 7, 2021

DAC overlays (#4154)

9c8d856

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request May 13, 2021

DAC overlays (#4154)

e683d01

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

popcornmix pushed a commit that referenced this pull request May 19, 2021

DAC overlays (#4154)

98d7b0c

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

Noltari pushed a commit to Noltari/rpi-linux that referenced this pull request Aug 20, 2021

DAC overlays (raspberrypi#4154)

58e6a45

Adding overlays for PiFi DAC Zero and PiFi DAC HD. Signed-off-by: David Knell <david.knell@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAC overlays #4154

DAC overlays #4154

pifi-bz commented Feb 18, 2021

pelwell left a comment

pelwell Feb 18, 2021

pelwell Feb 18, 2021

pelwell Feb 18, 2021

pelwell Feb 18, 2021

pelwell Feb 18, 2021

pelwell Feb 18, 2021

pelwell Feb 18, 2021

pifi-bz commented Feb 19, 2021

pelwell commented Feb 19, 2021

pifi-bz commented Feb 19, 2021

pelwell Feb 19, 2021

pifi-bz Feb 19, 2021


		status = "okay";

		playback_link: simple-audio-card,dai-link@1 {

		Params: <None>


		Name: pifi-dac-hd

DAC overlays #4154

DAC overlays #4154

Conversation

pifi-bz commented Feb 18, 2021

pelwell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pifi-bz commented Feb 19, 2021

pelwell commented Feb 19, 2021

pifi-bz commented Feb 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment