Some fixes to make imx290/imx327 exposure and vblank updates work correctly #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should now correspond exactly to the datasheet. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
When vblank changes we must modify the exposure range. Also, with this sensor, the effective exposure time implicitly changes when vblank does, so we have to reset it after every vblank update. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
|
I haven't checked against the datasheet, but the changes look reasonable. |
|
LGTM |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 22, 2021
kernel: PiFi DAC overlays See: raspberrypi/linux#4154 kernel: staging: rpivid: Fix crash when CMA alloc fails See: raspberrypi/linux#4152 kernel: Imx477 long exposure control See: raspberrypi/linux#4150 kernel: configs: Change CONFIG_BLK_DEV_NVME=y for 2711 See: raspberrypi/linux#4164 kernel: Some fixes to make imx290/imx327 exposure and vblank updates work correctly See: raspberrypi/linux#4153 kernel: KMS VGA666 overlay See: raspberrypi/linux#4141 kernel: gpio-fsm: Fix shutdown timeout handling kernel: configs: Add various missing IPV6 modules See: raspberrypi/linux#4144
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Feb 22, 2021
kernel: PiFi DAC overlays See: raspberrypi/linux#4154 kernel: staging: rpivid: Fix crash when CMA alloc fails See: raspberrypi/linux#4152 kernel: Imx477 long exposure control See: raspberrypi/linux#4150 kernel: configs: Change CONFIG_BLK_DEV_NVME=y for 2711 See: raspberrypi/linux#4164 kernel: Some fixes to make imx290/imx327 exposure and vblank updates work correctly See: raspberrypi/linux#4153 kernel: KMS VGA666 overlay See: raspberrypi/linux#4141 kernel: gpio-fsm: Fix shutdown timeout handling kernel: configs: Add various missing IPV6 modules See: raspberrypi/linux#4144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@naushir @6by9
Just a few more small tweaks to make the driver work correctly with libcamera. Hopefully the commit messages and the changes themselves are reasonably self-explanatory. Thanks!