Crash iOS15 #36
Comments
|
Hmm, interesting. Do you have more info about the crash? What is the exception, stack trace, etc.? I will definitely look at this and fix the bug. |
|
Hi RastislavMirek, Thanks for your quick response and really good to hear you'll fix this! When I look at the stack trace, and based on how long it takes to crash, it seems like it's stuck in some loop. Here's the stack, of which I'm only copying about 10%:
|
|
Thank you. Will look into this ASAP. However, if you find time to find the fix in FlexColorPicker yourself, I will gladly accept a pull request. |
Same here! |
|
Guys I would really love to help ASAP, but the problem is I am still on Mac 11 Big Sur and I would need to update in order to be able to install a new XCode with iOS 15 support. I cannot do that yet. If somebody who is facing this problem can patch it and send a pull request that would be accepted and I will release a new CocoaPods version as well. Otherwise, you will have to wait for the patch a little bit. I apologize. |
|
@RastislavMirek This is the same issue I was having, we can tag one of these as duplicates. I may look into fixing this myself, as I can't use auto layout at all. Why do you need to update? I have Big Sur and am using Xcode 13 with iOS 15. |
|
I didn't have time to fully dive into it and I needed an update fast, so I fixed it using the ugliest code possible. I knew it was calling some methods over and over, probably a layoutIfNeeded() that automatically called something that then again called layoutIfNeeded(). So I just needed some booleans to only call these one time. First class: AdjustedHitBoxColorControl Second class: ColorPaletteControl Third class: ColorSliderControl |
|
Having the same crash here. :/ Can't wait for a proper fix! |
|
This should be fixed in 1.4.4 |
|
@RastislavMirek I will test it this weekend and let you know, thanks for the quick fix. |
@gintechsystems Did you have a chance to test? |
|
@RastislavMirek Yes, it is working now. I am curious though, why do we need to call layoutIfNeeded twice? Does it not work with one? I guess I would have to go through the code to see what is going on fully to understand...auto layout does work now however I was forced to set a width and height for the view, I couldn't just put it between two elements and it would scale correctly like normal. Something we can look into later. Anyway, just giving my thoughts. Thanks again for the fix! |
|
I am not sure actually why there are 2 calls to layoutIfNeeded. I coded this a long time ago and I forgot what problem I solved this way...
This is definitely an issue. Would you mind creating a separate issue for this with example code? I will look into it. |
|
@RastislavMirek Has it always been an issue? Sure, I can do that for you. I will get back to you when I have time....it may be a little. I have been busy at my FT job. |
|
@gintechsystems No, this is new. Ok, I will wait. Thanks. |
@RastislavMirek I plan to look at this over the weekend, will keep you updated. Thanks for the patience. |
|
I just got time to look at it, works great! I think it's even better because in the previous version the layout wasn't good when I rotated, but now it updates the layout nicely. Thanks! |
|
@RastislavMirek - Link to the zip file with an example of the issue I am running into as mentioned earlier, I am required to set a width and height otherwise it just shows the thumb but not the color wheel, which is interesting. I could be wrong but I don't think auto layout is working as I am expecting or it could be I am missing a constraint. All you should have to do is compile and run. I did build using Xcode 13. |
|
I plan on forking your library and seeing if I can help resolve this issue, along with understanding the need for multiple layout calls. |
I use a very simple color picker, just the default:
It has always worked perfectly, until iOS15. It seems to crash on this line:
The text was updated successfully, but these errors were encountered: