Dockerize FluxCP #212
Closed
Dockerize FluxCP #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from upstream
|
this is nice, |
|
This PR won't be merged while the configs are forced into env variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a drive to make my services more modular my infrastructure more scalable, I have begun dockerizing the athena/RO family of applications and I wish to contribute my changes back to the community so others may also benefit.
By using this docker container we reduce the dependency list of FluxCP to simply requiring the installation of docker, which will allow anyone to start using it immediately.
Instead of Apache, I use nginx for as the webserver and php-fpm. This results in a much lighter and faster webserver (though it may not be for everyone). I have written rewrite rules that are as close to the .htaccess as I could make it.
I pass in values to the configuration file via environment variables. Obviously there is a bit more work to be done in exposing all the configuration options to environment variables. That will be done by me at a later date or if someone is willing to make a PR with improvements in that domain.
Because I have made a bunch of changes to the repo that may/should not be immediately mergeable (because it is different from how most people are supposed to use it at the moment and will create support nightmares), please treat this PR as an RFC for a dockerized FluxCP that will be more easily deployable.