Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust EXP storage to uint64 #4377

Merged
merged 17 commits into from Jul 28, 2020
Merged

Adjust EXP storage to uint64 #4377

merged 17 commits into from Jul 28, 2020

Conversation

cydh
Copy link
Contributor

@cydh cydh commented Oct 1, 2019 •
edited

  • Addressed Issue(s):
  • Server Mode: Both
  • Description of Pull Request:

PS

Just someone try to confirm if the EXP correct or not, before they change the table!!
If someone say wrong without correction, I will revert the EXP changes!!
Forgot the job_db2.txt

@cydh
EXP value is now uint64
904de72 
* Changed EXP tables for 185/65 updates
@attackjom
Copy link
Contributor

Very good job

@JohnnyPlayy
Copy link
Contributor

It was very good😍
image
Red Aura works great on client 2018-06-21aRagexeRE

@stevenahoy
Copy link

im using 20180621a client how to get lvl 185 and using last rathena? are you edit manualy in database ? because my base lvl still in 175/60

@attackjom
Copy link
Contributor

Can we skip these to 200/70 table

@aleos89
Copy link
Contributor

aleos89 commented Oct 15, 2019

It is the plan, but currently the table is a giant image from the release notes.

@rathena rathena deleted a comment from cydh Nov 13, 2019
@rathena rathena deleted a comment from RagnaWay Nov 13, 2019
@reunite-ro
Copy link
Contributor

Since 3rd job 16th anniversary patch has been added, this pull should be good to be merged too right ?

@Lemongrass3110
Copy link
Member

Since 3rd job 16th anniversary patch has been added, this pull should be good to be merged too right ?

Not yet.

@RagnaWay

This comment was marked as spam.

Sign in to view
@sader1992 sader1992 mentioned this pull request Apr 28, 2020
Closed
Lemongrass3110 referenced this pull request Jun 5, 2020
@Lemongrass3110
Initial support for newer packet versions (#4944)
45cd580 
Basic support for packets up to April 2020
Changing the default packet version to 2020-04-01

Thanks to everyone involved!
@admkakaroto
Copy link
Contributor

This needs to be upgraded to level 200.

@aleos89
Removes expType
91153b5 
* Always store exp as uint64 no matter the client date.
* Adjusts guild exp to uint64.
@admkakaroto
Copy link
Contributor

Level 200 exp table: https://ro.gnjoy.com/news/update/View.asp?seq=242

@ecdarreola
Copy link

From the service_korea lua files the max job level for doram is still at 60. (latest data.grf -kro)

image

@aleos89
Copy link
Contributor

aleos89 commented Jul 2, 2020

Maybe they forgot to update the LUA? The table in @admkakaroto's link shows Doram going from 65 -> 70.

@ecdarreola
Copy link

Maybe they forgot to update the LUA? The table in @admkakaroto's link shows Doram going from 65 -> 70.

Ah yeah maybe just lua forgotten.

@aleos89 aleos89 changed the title EXP value is now uint64 Adjust EXP storage to uint64 Jul 24, 2020
Lemongrass3110
Lemongrass3110 requested changes Jul 24, 2020
View reviewed changes
Copy link
Member

@Lemongrass3110 Lemongrass3110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust MAX_LEVEL_BASE_EXP and MAX_LEVEL_JOB_EXP to const t_exp as well :-)

src/char/char.cpp Outdated Show resolved Hide resolved
src/char/char.cpp Outdated Show resolved Hide resolved
src/char/char.cpp Outdated Show resolved Hide resolved
src/char/char.cpp Outdated Show resolved Hide resolved
src/char/int_guild.cpp Outdated Show resolved Hide resolved
src/map/pc.cpp Outdated Show resolved Hide resolved
src/map/pc.cpp Outdated Show resolved Hide resolved
src/map/pc.cpp Outdated Show resolved Hide resolved
src/map/pc.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
aleos89 and others added 3 commits July 24, 2020 18:49
@aleos89 @Lemongrass3110
Apply suggestions from code review
ca669b1 
Thanks to @Lemongrass3110!

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
@Lemongrass3110
Cleanups
06bf929
@Lemongrass3110
Added missing checks
7a4c334
@Lemongrass3110 Lemongrass3110 added component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode type:bug Issue that is a bug within rAthena labels Jul 28, 2020
@aleos89
Cleans up safe_addition
b436df9 
* Converts to a template to be more modular.
* Adjusts safe_addition_cap to also be modular.
* Removes GCC macro.
Thanks to @Lemongrass3110!
@aleos89
Renames SQL upgrade script
e374afa
@aleos89
Adds back GCC buildin for faster processing
76c00e4
@aleos89 aleos89 merged commit 1658f27 into master Jul 28, 2020
@aleos89 aleos89 deleted the feature/uint64_exp branch July 28, 2020 20:43
@edwardlucian
Copy link

Captureds
Capturedss
Help plz

@admkakaroto admkakaroto mentioned this pull request Aug 15, 2020
Closed
@aleos89 aleos89 mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemongrass3110 Lemongrass3110 Lemongrass3110 approved these changes

@aleos89 aleos89 aleos89 approved these changes

Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet