-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding basic metrics support #177
Conversation
Fix links to API javadoc
Had to change some error handling around for a reason I don't fully understand. It was a necessary change anyway.
Request completion callback functionality
Closes #187.
I've made the changes from your comments but as usual this pull request is looking messy now. Do you want me to create a new one? Not sure what I'm doing wrong but will try and find out. The main commit of interest is this one rhart@afd9c0e It's really hard to hook into the close event stuff from the aspect. I just don't have access to the |
I think the commit history mess might be from rebasing on pull instead of merging. I'm going to pull this and I'll clean it up on my side. |
Pulled. |
Initial commit for your review on the approach. I chose to use AOP as it means less noise in the code and will be more flexible going forward than using Guice method interceptors e.g. for non Guice objects. Can easily be changed though if the extra dependencies and/or JVM arg required to activate are a problem.
Usage would be as follows
You can see that custom metrics would be easily supported. Would also intend on providing an annotation to make it even easier.
Additional modules would be created to support the other reporters.
JVM arg is required though to active AOP
Feel free to tear into it and I will make any changes :)