Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic functional testing section to the manual. #192

Merged
merged 2 commits into from
Jan 1, 2014

Conversation

beckje01
Copy link
Member

@beckje01 beckje01 commented Dec 2, 2013

Including a section for Geb and TestHttpClient.

@ldaley
Copy link
Member

ldaley commented Dec 13, 2013

Thanks Jeff.

One problem with this is that the code is untested. I don't want to have any untested code in the docs. Using Spock and Geb is problematic here.

Two options:

  1. Don't use Spock in the examples and just write Groovy scripting with asserts
  2. Link to examples on GitHub that are tested (which means they have to be in the Ratpack build)

We want our build to support example apps in general that we test. This is something we need to set up.

@beckje01
Copy link
Member Author

I'm leaning towards doing option 1 that sound fine?

@ldaley
Copy link
Member

ldaley commented Dec 13, 2013

Sounds good.

@ldaley
Copy link
Member

ldaley commented Dec 29, 2013

What's happening with this @beckje01 ?

@ghost ghost assigned ldaley Dec 30, 2013
@beckje01
Copy link
Member Author

I'm getting on it now sorry about the delay

ldaley added a commit that referenced this pull request Jan 1, 2014
Added basic functional testing section to the manual.
@ldaley ldaley merged commit 99f115c into ratpack:master Jan 1, 2014
@beckje01 beckje01 deleted the functionalTestingManual branch January 10, 2014 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants