src/bundle: prefix manifest load errors with hint on manifest #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we only forward the parsing errors from load_manifest_*() methods, they will look like: | Failed to create bundle: Key file contains line 'EOF' which is not a key-value pair, group, or comment This does no real indication that it's the manifest that RAUC failed to read and will thus not be very helpful for people who are not that deep into RAUC. With the prefix, we get a better hint now: | Failed to create bundle: Failed to load manifest: Key file contains line ?EOF? which is not a key-value pair, group, or comment Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1348 +/- ##
==========================================
- Coverage 79.96% 79.95% -0.01%
==========================================
Files 67 67
Lines 20060 20060
==========================================
- Hits 16040 16038 -2
- Misses 4020 4022 +2 ☔ View full report in Codecov by Sentry. |
jluebbe
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we only forward the parsing errors from load_manifest_*() methods, they will look like:
This does no real indication that it's the manifest that RAUC failed to read and will thus not be very helpful for people who are not that deep into RAUC.
With the prefix, we get a better hint now: