Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/bundle: prefix manifest load errors with hint on manifest #1348

Merged
merged 1 commit into from
Feb 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/bundle.c
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,8 @@

res = load_manifest_file(manifestpath, &manifest, &ierror);
if (!res) {
g_propagate_error(error, ierror);
g_propagate_prefixed_error(error, ierror,

Check warning on line 899 in src/bundle.c

View check run for this annotation

Codecov / codecov/patch

src/bundle.c#L899

Added line #L899 was not covered by tests
"Failed to load manifest: ");
goto out;
}

Expand Down Expand Up @@ -1126,7 +1127,8 @@
/* Load manifest from content/ dir */
res = load_manifest_file(mfpath, &manifest, &ierror);
if (!res) {
g_propagate_error(error, ierror);
g_propagate_prefixed_error(error, ierror,

Check warning on line 1130 in src/bundle.c

View check run for this annotation

Codecov / codecov/patch

src/bundle.c#L1130

Added line #L1130 was not covered by tests
"Failed to load manifest: ");
goto out;
}

Expand Down Expand Up @@ -2219,7 +2221,8 @@
} else {
res = load_manifest_from_bundle(bundle, &loaded_manifest, &ierror);
if (!res) {
g_propagate_error(error, ierror);
g_propagate_prefixed_error(error, ierror,

Check warning on line 2224 in src/bundle.c

View check run for this annotation

Codecov / codecov/patch

src/bundle.c#L2224

Added line #L2224 was not covered by tests
"Failed to load manifest: ");
goto out;
}
manifest = loaded_manifest;
Expand Down