fix some memory leaks in the NBD server and enable asan for the tests #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move some local variables to a smaller scope. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
As we don't need the headers in GStrv form, remove that struct member and convert them to curl_slists immediately. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Now that the remaining memory leaks are fixed, we can enable address sanitizer in CI. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1374 +/- ##
==========================================
- Coverage 79.95% 79.92% -0.04%
==========================================
Files 67 67
Lines 20057 20066 +9
==========================================
+ Hits 16037 16038 +1
- Misses 4020 4028 +8 ☔ View full report in Codecov by Sentry. |
ejoerns
reviewed
Apr 4, 2024
|
|
||
| /* only read from the client on the first try */ | ||
| if (!ctx->url) { | ||
| g_autofree guint8 *data = g_malloc(xfer->request.len); | ||
| g_autoptr(GVariant) v = NULL; | ||
| g_auto(GVariantDict) dict = G_VARIANT_DICT_INIT(NULL); |
There was a problem hiding this comment.
Maybe note that this changes from stack-allocated to heap-allocated and that the former variant lacked the g_variant_dict_clear() call?
Also, the commit contains an unrelated newline change and unrelated code move. But since the result is still clear enough to read I'd be fine with that.
There was a problem hiding this comment.
This is still stack-allocated, which is what g_auto is used for.
ejoerns
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the nbd asan tests are not running in the CI, as we're not using qemu there, yet.