Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some memory leaks in the NBD server and enable asan for the tests #1374

Merged
merged 7 commits into from Apr 4, 2024
Merged

fix some memory leaks in the NBD server and enable asan for the tests #1374

merged 7 commits into from Apr 4, 2024

Commits on Mar 28, 2024

  1. src/nbd: fix memory leak of GVariantDict contents 

    Also move some local variables to a smaller scope.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
    @jluebbe
    jluebbe committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ff3836b View commit details
    Browse the repository at this point in the history

  2. src/nbd: fix leaks of configuration strings in the NBD server 

    Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
    @jluebbe
    jluebbe committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    aecc3ad View commit details
    Browse the repository at this point in the history

  3. src/nbd: fix string leak 

    Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
    @jluebbe
    jluebbe committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    72c811a View commit details
    Browse the repository at this point in the history

  4. src/nbd: fix leak of disconnect request 

    Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
    @jluebbe
    jluebbe committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fc777f6 View commit details
    Browse the repository at this point in the history

  5. src/nbd: fix memory leak on error shutdown 

    Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
    @jluebbe
    jluebbe committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a95ce8f View commit details
    Browse the repository at this point in the history

  6. src/nbd: fix leak of headers GStrv 

    As we don't need the headers in GStrv form, remove that struct member
and convert them to curl_slists immediately.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
    @jluebbe
    jluebbe committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    68ebdd0 View commit details
    Browse the repository at this point in the history

  7. .github/workflows/sanitizers: enable tests for nbd 

    Now that the remaining memory leaks are fixed, we can enable address
sanitizer in CI.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
    @jluebbe
    jluebbe committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    372fce7 View commit details
    Browse the repository at this point in the history