Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete quoting for parameters of some CMake commands #5

Open
elfring opened this issue Jan 28, 2016 · 0 comments
Open

Complete quoting for parameters of some CMake commands #5

elfring opened this issue Jan 28, 2016 · 0 comments

Comments

@elfring
Copy link

elfring commented Jan 28, 2016

Some parameters (like "${PROJECT_SOURCE_DIR}/include") are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.
@HeatherHu HeatherHu mentioned this issue Oct 17, 2016
Open
@gs14iitbbs gs14iitbbs mentioned this issue Feb 17, 2017
Closed
@crey0 crey0 mentioned this issue Jun 8, 2017
Open
marco-tranzatto pushed a commit to marco-tranzatto/ORB_SLAM2 that referenced this issue Jun 14, 2017
@grafue
Merge pull request raulmur#5 from grafue/doc/Release
20321d9 
Merge documentation
@JoeyDow JoeyDow mentioned this issue Jul 3, 2018
Open
tnassour pushed a commit to tnassour/ORB_SLAM2 that referenced this issue Aug 6, 2019
@bradleynull
Merge pull request raulmur#5 from monoDriveIO/less_cores
f0d5c42 
Make using too many cores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elfring