Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github emoji not showing and Syntax highlighting not work #14

Closed
muhsalaaio opened this issue Nov 29, 2019 · 3 comments
Closed

github emoji not showing and Syntax highlighting not work #14

muhsalaaio opened this issue Nov 29, 2019 · 3 comments
Labels
bug Something isn't working question Further information is requested

Comments

@muhsalaaio
Copy link

hi i have issue when using emoji and add javascript syntax on markdown-it-vue

here is my code

<markdown-it-vue class="md-body" :content="markdownText" :options="options"/>

and this is the script

<script>
import MarkdownItVue from 'markdown-it-vue';
import 'markdown-it-vue/dist/markdown-it-vue.css';
import datane from '../markdown/materi.md';

export default {
  components: {
    MarkdownItVue
  },
  data() {
    return {
      options: {
        markdownIt: {
          linkify: true,
          html: true,
        }
      }
    }
  },
  computed: {
    markdownText() {
      return datane;
    }
  }
}
</script>

but the emoji and syntax not highlighted

Emoji not showing,

should be like this:

Syntax not highlighted

should be like this

is it a bug or am i missing something?

@ravenq
Copy link
Owner

ravenq commented Dec 1, 2019

Thanks for you issue:

  1. There is a bug in the 'markdow-it-highlight' plugin. It not highlight the code when it not asign the lang in the token. And in the new vesion,it will detect the lang automatically.
    Here the commit: 9906869
  2. It does work in my demo for the Emoji http://122.51.246.153/markdown

图片
It may need more infomation.

@ravenq ravenq added bug Something isn't working question Further information is requested labels Dec 1, 2019
@muhsalaa
Copy link

muhsalaa commented Dec 3, 2019

I found out the red code and not working highlighting is because use of this pakcage along with vuetify

@ravenq
Copy link
Owner

ravenq commented Dec 29, 2019

图片

it can work.but it be affected by the global css.

@ravenq ravenq closed this as completed May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants