Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS vulnerability may exist in Exception page #202

Closed
Goyotan opened this issue Jan 23, 2020 · 1 comment
Closed

XSS vulnerability may exist in Exception page #202

Goyotan opened this issue Jan 23, 2020 · 1 comment

Comments

@Goyotan
Copy link

Goyotan commented Jan 23, 2020

Hello developers of this cool software!

I found a problem that is the potential of XSS vulnerability.

function getMainMessage() in Unbound.php displays
exception details like exception exception\hoge with message deadbeef.

If result of $e->getMessage() contains user input and display it, It becomes vulnerable against XSS.
Because result of $e->getMessage() is passed to sprintf without escaping html characters.

Example of similar problem: https://hackerone.com/reports/216812

Thank you.

@koriym
Copy link
Member

koriym commented Jan 24, 2020

The html escape should be handled in the view side?

@koriym koriym closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants