Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Priority Class Name from worker group spec not forwarded to final templated yaml files #2086

Open
2 tasks done
sam-h-bean opened this issue Apr 17, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working triage

Comments

@sam-h-bean
Copy link

sam-h-bean commented Apr 17, 2024

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ray-operator, Others

What happened + What you expected to happen

I added a priority class name to both my head spec and worker spec. When I inspect the final templated yaml coming from the Kuberay CRD I see that the priority class name is included for the head group but not the worker group. This has the effect of transparently dropping the priority class name in the worker group spec. Upon manually editing the RayCluster CRD on kubernetes to insert the priority class name, it is forwarded to the pod definitions.

Reproduction script

Just include a priority class name in RayCluster object in yaml for head spec and worker spec.kubectl describe RayCluster my-cluster will then show you the priority class name is shown in the head spec but dropped for worker spec.

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@sam-h-bean sam-h-bean added bug Something isn't working triage labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

1 participant