Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] RayCluster Helm Chart: Add pod level securityContext in addition to container level securityContext #2136

Closed
2 tasks done
arueth opened this issue May 10, 2024 · 3 comments
Closed
2 tasks done

[Feature] RayCluster Helm Chart: Add pod level securityContext in addition to container level securityContext #2136

arueth opened this issue May 10, 2024 · 3 comments
Assignees
@arueth
Labels
enhancement New feature or request Helm Tracks improvements to Helm support

Comments

@arueth
Copy link
Contributor

arueth commented May 10, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently you can only set the securityContext at the container level with the RayCluster Helm chart.

Use case

Some compliance tools scan for securityContext at both the Pod and Container level. You should be able to set the securityContext at both levels.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@arueth arueth added enhancement New feature or request triage labels May 10, 2024
@kevin85421 kevin85421 added Helm Tracks improvements to Helm support and removed triage labels May 13, 2024
@kevin85421
Copy link
Member

@arueth Are you interested in opening a PR? Thanks!

@arueth
Copy link
Contributor Author

arueth commented May 17, 2024

Do I create a PR against:
https://github.com/ray-project/kuberay/tree/master/helm-chart/ray-cluster
or
https://github.com/ray-project/kuberay-helm/tree/main/helm-chart/ray-cluster

@kevin85421
Copy link
Member

@arueth, you can open a PR for the KubeRay repository, and I will update kuberay-helm when preparing for the next release.

@arueth arueth mentioned this issue May 20, 2024
Merged
4 tasks
@arueth arueth closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arueth arueth

Labels
enhancement New feature or request Helm Tracks improvements to Helm support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevin85421 @arueth