Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] RayService CRD to have ImagePullSecret Reference #2137

Open
1 of 2 tasks
roverkinz opened this issue May 10, 2024 · 1 comment
Open
1 of 2 tasks

[Feature] RayService CRD to have ImagePullSecret Reference #2137

roverkinz opened this issue May 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@roverkinz
Copy link

roverkinz commented May 10, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

This feature can help to pull images from private repo. This is helpful in cases where we want to refer working directory as local path, and use custom docker image with application code using the base docker image as rayproject/ray-ml image

Use case

I am working towards application isolation by developing a custom Docker image that encapsulates a Python script unique to each application. Given the proprietary nature of my application logic, using public references is not feasible. Additionally, this approach simplifies the release and deployment process on Kubernetes, moving away from zip file references. It also allows greater control over the operating system level configurations of the image, beyond just the Python code included in the zip.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@roverkinz roverkinz added enhancement New feature or request triage labels May 10, 2024
@kevin85421 kevin85421 removed the triage label Jul 12, 2024
@kevin85421
Copy link
Member

RayService CRD exposes the whole Pod spec. I think you can directly specify ImagePullSecret in the Pod spec. Do I misunderstand anything? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants