Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Operator watch resource needs to be optimized #403

Closed
1 of 2 tasks
Jeffwan opened this issue Jul 23, 2022 · 1 comment
Closed
1 of 2 tasks

[Bug] Operator watch resource needs to be optimized #403

Jeffwan opened this issue Jul 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working P1 Issue that should be fixed within a few weeks

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 23, 2022

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ray-operator

What happened + What you expected to happen

image

HA Feature added some logic to reconcile events. We can see some unrelated pods are filtered out. This should be optimized to filter to watch and reconcile kuberay specific resources.

Reproduction script

Just start the operator and watch logs

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Jeffwan Jeffwan added the bug Something isn't working label Jul 23, 2022
@Jeffwan Jeffwan added this to the v0.4.0 release milestone Jul 27, 2022
@DmitriGekhtman DmitriGekhtman added the P1 Issue that should be fixed within a few weeks label Nov 4, 2022
@kevin85421
Copy link
Member

The filter for Kubernetes events is improved by #946. It will still receive some unrelated events, but filter all events in the resource event filters requiring two lookup operations for the local cache. See the PR description of #996 for more details. The next step may remove the Kubernetes informer. Close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

7 participants