[Doc] [RayJob] Add documentation for submitterPodTemplate #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
kevin85421
reviewed
Jul 10, 2023
|
|
||
| You can use `kubectl logs` to check the operator logs or the head/worker nodes logs. | ||
| You can also use `kubectl describe rayjobs rayjob-sample` to check the states and event logs of your RayJob instance: | ||
|
|
||
| ``` | ||
| ```text | ||
| Status: |
There was a problem hiding this comment.
Does the status remain the same after the refactoring?
There was a problem hiding this comment.
Yes, it looks the same. I've pasted the status from a more recent run.
| If the job doesn't run successfully, the above `describe` command will provide information about that too: | ||
| ``` | ||
|
|
||
| ```text | ||
| Status: |
There was a problem hiding this comment.
Does the status remain the same after the refactoring?
kevin85421
approved these changes
Jul 10, 2023
|
I will double check the status after testing it manually, and update the
sample terminal output in this PR.
…On Mon, Jul 10, 2023 at 1:50 PM Kai-Hsun Chen ***@***.***> wrote:
***@***.**** approved this pull request.
I have just approved this PR due to the urgency of the release.
—
Reply to this email directly, view it on GitHub
<#1228 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJU5RU5H4TDXEWGDMD5NKLXPRTIHANCNFSM6AAAAAA2E6LGQI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
The sample YAML succeeded. I don't see a way to get the correct |
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
The compatibility test is unrelated. @kevin85421 if no other comments after my latest changes, I will merge the PR. |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…t#1228) Updates the sample YAML to include submitterPodTemplate. Commented out because it's optional. Updates the markdown doc to include submitterPodTemplate. Miscellaneous fixes, such as adding missing fields to the doc or sample YAML. TODO before merge: Manual test: run sample YAML with submitterPodTemplate uncommented. Related issue number Closes ray-project#1227 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
TODO before merge:
Related issue number
Closes #1227
Checks