-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] [RayJob] Add documentation for submitterPodTemplate #1228
[Doc] [RayJob] Add documentation for submitterPodTemplate #1228
Conversation
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
||
You can use `kubectl logs` to check the operator logs or the head/worker nodes logs. | ||
You can also use `kubectl describe rayjobs rayjob-sample` to check the states and event logs of your RayJob instance: | ||
|
||
``` | ||
```text | ||
Status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the status remain the same after the refactoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it looks the same. I've pasted the status from a more recent run.
If the job doesn't run successfully, the above `describe` command will provide information about that too: | ||
``` | ||
|
||
```text | ||
Status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the status remain the same after the refactoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just approved this PR due to the urgency of the release.
I will double check the status after testing it manually, and update the
sample terminal output in this PR.
…On Mon, Jul 10, 2023 at 1:50 PM Kai-Hsun Chen ***@***.***> wrote:
***@***.**** approved this pull request.
I have just approved this PR due to the urgency of the release.
—
Reply to this email directly, view it on GitHub
<#1228 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJU5RU5H4TDXEWGDMD5NKLXPRTIHANCNFSM6AAAAAA2E6LGQI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
The sample YAML succeeded. I don't see a way to get the correct |
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
The compatibility test is unrelated. @kevin85421 if no other comments after my latest changes, I will merge the PR. |
…t#1228) Updates the sample YAML to include submitterPodTemplate. Commented out because it's optional. Updates the markdown doc to include submitterPodTemplate. Miscellaneous fixes, such as adding missing fields to the doc or sample YAML. TODO before merge: Manual test: run sample YAML with submitterPodTemplate uncommented. Related issue number Closes ray-project#1227 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Why are these changes needed?
TODO before merge:
Related issue number
Closes #1227
Checks