Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] [RayJob] Ensure doc and sample YAML uses new SubmitterPodSpec field #1227

Closed
architkulkarni opened this issue Jul 10, 2023 · 0 comments · Fixed by #1228
Closed

[Doc] [RayJob] Ensure doc and sample YAML uses new SubmitterPodSpec field #1227

architkulkarni opened this issue Jul 10, 2023 · 0 comments · Fixed by #1228
Assignees
@architkulkarni
Labels
docs Improvements or additions to documentation rayjob

Comments

@architkulkarni
Copy link
Contributor

In #1177 a new optional field SubmitterPodTemplate was added. This needs to be documented and added in the sample YAML file (we can comment it out in the sample YAML file because it's optional and we don't expect most users to need to touch it.)
@architkulkarni architkulkarni added docs Improvements or additions to documentation rayjob labels Jul 10, 2023
@architkulkarni architkulkarni self-assigned this Jul 10, 2023
@architkulkarni architkulkarni mentioned this issue Jul 10, 2023
Merged
5 tasks
architkulkarni added a commit that referenced this issue Jul 11, 2023
@architkulkarni
[Doc] [RayJob] Add documentation for submitterPodTemplate (#1228)
adde70c 
Updates the sample YAML to include submitterPodTemplate. Commented out because it's optional.
Updates the markdown doc to include submitterPodTemplate.
Miscellaneous fixes, such as adding missing fields to the doc or sample YAML.
TODO before merge:

 Manual test: run sample YAML with submitterPodTemplate uncommented.
Related issue number
Closes #1227

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this issue Sep 24, 2023
@architkulkarni
[Doc] [RayJob] Add documentation for submitterPodTemplate (ray-projec…
63cf940 
…t#1228)

Updates the sample YAML to include submitterPodTemplate. Commented out because it's optional.
Updates the markdown doc to include submitterPodTemplate.
Miscellaneous fixes, such as adding missing fields to the doc or sample YAML.
TODO before merge:

 Manual test: run sample YAML with submitterPodTemplate uncommented.
Related issue number
Closes ray-project#1227

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@architkulkarni architkulkarni

Labels
docs Improvements or additions to documentation rayjob
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Doc] [RayJob] Add documentation for submitterPodTemplate architkulkarni/kuberay
1 participant
@architkulkarni