-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KubeRay: Relocate files to enable controller extension with Kubebuilder #268
Conversation
Seem PR makes following changes to prepare for next PR.
|
The change looks good to me. Please double check whether the common used Make commands works. I think CI covers some of them. |
@@ -82,14 +82,14 @@ docker-push: ## Push docker image with the manager. | |||
##@ Deployment | |||
|
|||
install: manifests kustomize ## Install CRDs into the K8s cluster specified in ~/.kube/config. | |||
$(KUSTOMIZE) build config/crd | kubectl apply -f - | |||
($(KUSTOMIZE) build config/crd | kubectl create -f -) || ($(KUSTOMIZE) build config/crd | kubectl replace -f -) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use create and replace instead of apply due to
The CustomResourceDefinition "rayclusters.ray.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
Thanks. I do |
@@ -321,10 +321,53 @@ spec: | |||
of {key,value} pairs. | |||
type: object | |||
type: object | |||
namespaceSelector: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also saw these changes when running Make manifests locally.
It looks like the embedded pod template has been updated to a newer Kubernetes version (namespaceSelector
was introduced in K8s 1.21).
Looks like some component was upgraded from K8s 1.19 to 1.23 in this PR? Not sure if that's related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Due to that version upgrade, controller-runtime
was upgraded as well. namespaceSelector was introduced to extend pod affinity (it's still alpha in 1.21).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still compatible with 1.19 cluster and user needs to use kubectl replace -f xx.yaml
to upgrade crd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have the CI run Make manifests and check for changes? Maybe also a pre-push hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in CI please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me open an issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…er (ray-project#268) * KubeRay: Relocate files to enable controller extension with Kubebuilder * update suite test * address comments * Fix apply issue * make manifests
Why are these changes needed?
As discussed, we want to have more controllers for serve and job. This pr relocates controller files to enable future api create by kubebuilder
Related issue number
#214
Checks