-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up example samples #434
Clean up example samples #434
Conversation
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
block: 'true' | ||
num-cpus: '1' # can be auto-completed from the limits | ||
# num-cpus: '1' # can be auto-completed from the limits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a foot-gun for people copying the config and modifying resource values. Hence, commented out.
great. These configuration are covered by codes. Looks good to me |
We could consider automatically configuring the init container and pre-stop hook in the 0.4.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just going to double check that the configs don't have any issues before merging. |
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
This PR cleans up the "complete" and "autoscaler" sample yamls a bit. Unnecessary pod spec fields are removed without sacrificing the completeness of the examples. The idea is to make the configuration look less intimidating. Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
* Fix nil pointer dereference (#429) Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix wrong ray start command (#431) Signed-off-by: Kevin Su <pingsutw@apache.org> * Add ray state api doc link in ray service doc (#428) * Add ray state api doc link in ray service doc * Update doc * update * [doc] Fix config typos Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> Fixes a couple of typos in recently introduced sample configs. * Add http resp code check for kuberay (#435) * Clean up example samples (#434) This PR cleans up the "complete" and "autoscaler" sample yamls a bit. Unnecessary pod spec fields are removed without sacrificing the completeness of the examples. The idea is to make the configuration look less intimidating. Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> * Add more env for RayService head or worker pods (#439) * fix: worker node can't connect to head node service (#445) Signed-off-by: Kevin Su <pingsutw@apache.org> * helm-chart/ray-cluster: allow head autoscaling (#443) Also allow setting rayVersion Signed-off-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com> * Disable async serve handler in Ray Service cluster (#447) * Add wget timeout to probes (#448) * Enable tests against release-0.3 branch Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> Signed-off-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Co-authored-by: bruce <103957904+brucez-anyscale@users.noreply.github.com> Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Co-authored-by: Christos Kotsis <28815556+ulfox@users.noreply.github.com> Co-authored-by: Yi Cheng <74173148+iycheng@users.noreply.github.com> Co-authored-by: Wilson Wang <3913185+wilsonwang371@users.noreply.github.com>
env: | ||
- name: CPU_REQUEST | ||
valueFrom: | ||
resourceFieldRef: | ||
containerName: ray-head | ||
resource: requests.cpu | ||
- name: CPU_LIMITS | ||
valueFrom: | ||
resourceFieldRef: | ||
containerName: ray-head | ||
resource: limits.cpu | ||
- name: MEMORY_LIMITS | ||
valueFrom: | ||
resourceFieldRef: | ||
containerName: ray-head | ||
resource: limits.memory | ||
- name: MEMORY_REQUESTS | ||
valueFrom: | ||
resourceFieldRef: | ||
containerName: ray-head | ||
resource: requests.memory | ||
- name: MY_POD_IP | ||
valueFrom: | ||
fieldRef: | ||
fieldPath: status.podIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitriGekhtman just curious if these env vars are deprecated and should no longer be used or if removing them will change Ray behavior? I'm using Ray 1.13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're deprecated and can be safely removed.
ports: | ||
- containerPort: 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitriGekhtman what did this port used to be? Should we add the metrics
port 8080?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what this port was doing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe that the operator interacts with ports specified in workerGroupSpecs.
This PR cleans up the "complete" and "autoscaler" sample yamls a bit. Unnecessary pod spec fields are removed without sacrificing the completeness of the examples. The idea is to make the configuration look less intimidating. Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Why are these changes needed?
This PR cleans up the "complete" and "autoscaler" sample yamls a bit.
Unnecessary pod spec fields are removed without sacrificing the completeness of the examples.
The idea is to make the configuration look less intimidating.
Related issue number
Checks